Best posts made by mcal9909

A Dealing mod.
Change Log
0.2.30

• New purchasable stash house system. (MAKE SURE YOU COPY OVER THE NEW LSLIFE_STASHHOUSE.XML to your LSLIFE FOLDER)
• Diamond Casino and Tequi-la-la added to valid dealing locations
• Fixed bug with time of Zees delivery.
• Fixed bug with workers weapon gaining the players weapon attachments upon hiring.
• Honking your horn while near a working dealer will make then follow you.
• Workers Menu will now show the workers current health and armour amount.
• If a following worker is injured and near a stash house or hospital they will attempt to heal themselfs.
  Hospitals are instant and cost money, stash houses heal over time and are free.
• Entering a stash house while workers are following will cause them to wait outside for you.
• Workers are now very effective in combat.
• Workers sales are now effected by the areas drug demands and amount of dealers in the area.
• Rivals accuracy, armour and shoot rating now has a base of 1 + (random number between 0 and GangStength*10)
• Peds standing on balconies should no longer be valid as customers or dealers.
• Driveby vehicle clean-up fixes.
• You can now dismiss Zee's drivers/dealers by calling for a new one.
• Hopefully fixed robbers blip disappearing.
• Other misc bug fixes and improvements.

0.2.30a

• Fixed dealers going under the map when spawned.
  0.2.30b
• Fixed the Stashouse.xml, You must use the new one supplied.
• Some changes to drivebys.

0.2.31

• New sprites for menus. Those of you that are updating make sure to copy the new sprites folder into your LSLIFE folder.
• Customers should no longer get so angry when bumping into them after a sale.
• Driveby peds skills and weapons will now scale with gang strength.
• The amount of peds in a drive by is now random.
• Overhauled drive by AI.
• Fixed an issue with workers healing at a hospital.
• Possible fix for a script crash when spawning a bag.

0.2.32

• New xml for the LsLife folder, LSLife_Spawns.xml. script will not work without it!
• Added option to ini to disable use of sprites in menus. (for ultra widescreen users)
• Buying drugs has changed, Now you must place an order with Zee, then collect this order from his people. The location of this meeting will be chosen at random from the LSLife_Spawns.xml (make sure you copy it into your LSLIFE folder).
• All Ounces purchased from a supplier must be stashed and converted to Grams at a stash house before they can be sold.
• Large amounts of drugs will require the use of a stash vehicle.
• A large amount of drugs will be defined as an amount that would bring your total carried drug inventory above 256oz.
• Credit limit is now increased by rep.
• Made changes to Rival dealer movement behaviour.
• Fixed bug with rival dealers spawns when player changes area.
• Killing or hiring a dealer will result in a boost to the current areas drug demands for a period of time. The length of this buff ranges from 10mins to 1 min, based on the local rivals strength.
• Amount of rivals in a driveby is now based on local rivals strength.
• Handing to or receiving money/drugs from a dealer will increase the areas Heat for a period of time, If seen by police will result in 2 stars, and if seen by a rival may result in them attacking you.
• Added Hard mode option to ini, This will adjust drug prices to a more realistic level, increase the total vehicles involved in a driveby.
• Hired workers will enter follow state when hired.
• Initial debt cap reduced from 100,000 to 1,000 when hardmode activated.
• Zee will only get $5k for free if he reloads with less than $1k in the bank when playing hardmode. Down from $50k/$10k.
• New UI element for displaying amounts carried. Same Key as before, but its now a toggle to display/hide.

0.2.33

• Fixed menu descriptions.
• Fixed Order menu not using sprites when option is turned on.
• Fixed money not being applied to Zee when paying Debt.
• Fixed weapons and armour reducing debt with Zee instead of increasing it.
• Debt cap now properly applies to weapons dealer.
• Added Markers option to ini, setting this to false will disable marker at the rear of a stash vehicle, entrance to a stash house and stash location.
• No Marker setting in the ini will default to true.
• Fixed not being able to interact with customers when in a vehicle while a customer is stood close to the vehicle.
• All ounces (un-processed) will be coloured red inside menus.

0.2.34

• Made improments to checking if a dealer is working or following.
• Fixed using vehicle Horn to make a dealer follow.
• New AreaDebug ini option for displaying Area Stats, enabling it will make the Inventory Key also display current Area stats.
• Fixed area demands being duplicated across all areas.
• Fixed area demands randomization.
• Rewrote GangGrowth function, should be more reliable.
• Fixed StashVehicle being incorrectly flagged as destroyed.

0.2.35

• Fix script crash a few people are having on placing order.
• Reset immune to player on worker despawn and script reset.
• Following workers who are removed from the players group will move to Followstate (ready to follow again if player is in range) and have events blocked.
• All custom relationship groups disposed of properly on script reset.

@dimedius You have 2 types of groups.

One type i would call a Team or a Squad. This group will have a leader and all members will fight along side / follow the leader, kind of protecting them (aslong as they are capable).
These groups have a maximum size of 7 (i believe this can be changed within the game files).

void MakeGroup()
        {
            PedGroup myGroup= new PedGroup();
            myGroup.Add(ped1, true);
            myGroup.Add(ped2, false);
            // or
            myGroup.Add(ped1, true)
            ped1.CurrentGroup.Add(ped2, false)
        }

Now if i tell ped1 to fight someone, ped 2 will join them.. If i tell ped 1 to get into a car ped 2 will also get into that car.
If someone attacks ped1, ped2 will attack them back. (aslong as they are within a certain distance of each other, groups have a maximum range at a member can be from its leader, reaching this max will cause the member to stop functioning as a group member)

Then there are Relationship groups, which are some basic parameters defining who the members of the relationship group like/dislike. Relationship groups do not have a leader or a maximum size and no one will follow anyone else, but they may fight together and even help each other out.
Think of relationship groups as a way of controlling how a ped reacts to a given situation without directly controlling the ped.
A ped who respects another ped, is more likely to help that respected ped if hes in trouble. A ped who dislikes another ped is more likely to attack that disliked ped.. There is a sliding scale from Companion to Enemy.
This is the system that controls gang members when they fight along side each other vs the cops or when Chamberlain gangs shoot at cops that are after Franklin, they respect Frank, so they help him.

        /// to make a new group
        public static int customers= World.AddRelationshipGroup("LSCUSTOMER");
        public static int workers = World.AddRelationshipGroup("LSWORKERS");
        public static int rival_nutral = World.AddRelationshipGroup("LSRIVAL_N");
        public static int rival_enemy = World.AddRelationshipGroup("LSRIVAL_E");

        /// to get an existing group, there are more possible strings for all the pre existing groups in the game
        public static int playerRelationship = Function.Call<int>(Hash.GET_HASH_KEY, "PLAYER");
                        
                        /// to configure the groups.
                        World.SetRelationshipBetweenGroups(Relationship.Pedestrians, workers , customers);
                        World.SetRelationshipBetweenGroups(Relationship.Companion, workers , playerRelationship);
                        World.SetRelationshipBetweenGroups(Relationship.Neutral, workers , rival_nutral);
                        World.SetRelationshipBetweenGroups(Relationship.Hate, workers , rival_enemy);
                        World.SetRelationshipBetweenGroups(Relationship.Pedestrians, playerRelationship, customers);
                        World.SetRelationshipBetweenGroups(Relationship.Companion, playerRelationship, workers);
                        World.SetRelationshipBetweenGroups(Relationship.Neutral, playerRelationship, rival_nutral);
                        World.SetRelationshipBetweenGroups(Relationship.Hate, playerRelationship, rival_nutral);
                        World.SetRelationshipBetweenGroups(Relationship.Pedestrians, rival_nutral, customers);
                        World.SetRelationshipBetweenGroups(Relationship.Neutral, rival_nutral, workers);
                        World.SetRelationshipBetweenGroups(Relationship.Neutral, rival_nutral, playerRelationship);
                        World.SetRelationshipBetweenGroups(Relationship.Respect, rival_nutral, rival_enemy);
                        World.SetRelationshipBetweenGroups(Relationship.Pedestrians, rival_enemy, customers);
                        World.SetRelationshipBetweenGroups(Relationship.Hate, rival_enemy, workers);
                        World.SetRelationshipBetweenGroups(Relationship.Hate, rival_enemy, playerRelationship);
                        World.SetRelationshipBetweenGroups(Relationship.Respect, rival_enemy, rival_nutral);
                        World.SetRelationshipBetweenGroups(Relationship.Companion, customers, workers);
                        World.SetRelationshipBetweenGroups(Relationship.Companion, customers, playerRelationship);
                        World.SetRelationshipBetweenGroups(Relationship.Companion, customers, rival_nutral);
                        World.SetRelationshipBetweenGroups(Relationship.Companion, customers, rival_enemy);

This is an example of how relationship groups are made, gotten and configured.

There exists a native that can be used to adjust this.

void SET_COMBAT_FLOAT(Ped ped, int combatType, float p2)

combatType of 12 = TimeToInvalidateInjuredTarget.

I am unsure if these values exists in some file and can be edited (they probably do), but they can be adjusted via a script.

Pretty sure an object keeps its frozen status for its lifetime.
You can "get" the status of a prop and use this to filter your array.

Prop[] nearbyProps = World.GetNearbyProps(playerPed.Position, 10f).Where(p => !p.FreezePosition);

or make a list.

List<Prop> frozenProps = new List<Prop>();
List<Int> propHashes = new List<Int>{1111, -1111, 2111};

and in ontick

if(frozenProps.Count > 0)
{
   foreach(Prop prop in frozenProps.ToList())
   {
      if(prop == null || !prop.Exists())
      {
         frozenProps.Remove(prop)
      }
   }   
}
Prop[] nearbyProps = World.GetNearbyProps(playerPed.Position, 100f).Where(p => propHashes.Contains(p.Model.Hash) && !frozenProps.Contains(p));
if(nearbyProps.Count > 0)
{
   foreach(Prop prop in nearbyProps)
   {
      prop.FreezePosition = true;
      frozenProps.Add(prop)
   }
}

It would depend on whats faster, checking if an object Exists, or if an object is frozen or not.
I see what you are doing with your latest revision, but i would just get all props within 100m or so of the player every 400ms(ish), filter that list of anything that is not a prop to be frozen and then freeze the remainder.

Just some ideas, but it should only require a tick every 400ms (could possibly go higher) instead of a tick every frame. Unless im wrong about a prop keeping its frozen status for its lifetime.

yep this might be of some help to you, Once started it will spawn peds at a random location chosen from the List of locations to fight the player every 500ms until there are 15 peds, and keep spawning new peds to replace the dead peds until its told to stop. Not exactly what you are after but it demonstrates how handle alot of peds with a relatively small amount of code.

class EnemyHandler
    {
        List<Vector3> SpawnLocations = new List<Vector3>
        {
           new Vector3 (-131.695f, -1509.14f, 34.10052f),
           new Vector3 (-161.0194f, -1515.375f, 33.68655f),
           new Vector3 (-172.2392f, -1492.894f, 32.55872f)
        };
        Vector3 ClosePos;
        List<Ped> Enemies = new List<Ped>();
        int MaxPeds = 15;
        int TimeBetweenSpawns = 500;
        int Time;
        public bool Started { get; private set; } = false;
        List<PedHash> pedHashes = new List<PedHash>
        {
            PedHash.AvonGoon,
            PedHash.Juggernaut01M
        };
        Random Rand = new Random();

        public EnemyHandler()
        {

        }

        public void Ontick()
        {
            if (Started)
            {
                if (Game.GameTime > Time + TimeBetweenSpawns && Enemies.Count < MaxPeds)
                {
                    int index = -1;
                    bool posFound = false;
                    ClosePos = SpawnLocations[0];
                    foreach (Vector3 v in SpawnLocations)
                    {
                        if (v.DistanceTo(Game.Player.Character.Position) < ClosePos.DistanceTo(Game.Player.Character.Position))
                        {
                            ClosePos = v;
                        }
                    }
                    while (!posFound)
                    {
                        index = Rand.Next(0, SpawnLocations.Count);
                        if (SpawnLocations[index] != ClosePos)
                        {
                            posFound = true;
                        }
                    }
                    int pedIndex = Rand.Next(0, 2);
                    Ped enemy = World.CreatePed(pedHashes[pedIndex], SpawnLocations[index]);
                    while (enemy == null)
                    {
                        Wait(0);
                    }
                    switch (pedIndex)
                    {
                        case 0:
                            enemy.Weapons.Give(WeaponHash.CarbineRifle, 1000, true, true);
                            Function.Call(Hash.SET_PED_COMBAT_MOVEMENT, enemy, 2);
                            break;
                        case 1:
                            enemy.Weapons.Give(WeaponHash.Minigun, 10000, true, true);
                            enemy.CanSufferCriticalHits = false;
                            enemy.Health = 4000;
                            Function.Call(Hash.SET_PED_COMBAT_MOVEMENT, enemy, 3);
                            break;
                    }
                    Function.Call(Hash.SET_PED_COMBAT_ABILITY, enemy, 100);
                    enemy.FiringPattern = FiringPattern.FullAuto;
                    enemy.CanWrithe = false;
                    enemy.Armor = 100;
                    enemy.RelationshipGroup = enemyTeam;
                    enemy.AlwaysKeepTask = true;
                    enemy.Task.FightAgainst(Game.Player.Character);
                    enemy.AddBlip();
                    enemy.CurrentBlip.IsFriendly = false;
                    Enemies.Add(enemy);
                    Time = Game.GameTime;
                }

            }
            CheckPeds();
        }

        public void Start()
        {
            Started = true;
        }

        public void Stop()
        {
            Started = false;
        }

        void CheckPeds()
        {
            if (Enemies.Count > 0)
            {
                foreach (Ped p in Enemies.ToList())
                {
                    if (p == null || !p.Exists())
                    {
                        Enemies.Remove(p);
                    }
                    else if (p.IsDead)
                    {
                        p.CurrentBlip.Remove();
                        Enemies.Remove(p);
                    }
                }
            }
        }

        void RemoveEnemies()
        {
            foreach (Ped p in Enemies.ToList())
            {
                p.CurrentBlip.Remove();
                Enemies.Remove(p);
            }
        }
    }

No, a relasionship groups is not a collection that can be iterated. Its just an int
Sounds like you want to use a List<Ped> and add all your peds to that.

@briancatmaster

First define your relationship group and its relationships with other groups when your script starts

public static int someRelationshipGroup = World.AddRelationshipGroup("RGROUPNAME");  // make sure the string is unique and unlikley to be used by other mods
public static int playerRelationship = Function.Call<int>(Hash.GET_HASH_KEY, "PLAYER");

World.SetRelationshipBetweenGroups(Relationship.Hate, playerRelationship, someRelationshipGroup );        
World.SetRelationshipBetweenGroups(Relationship.Hate, someRelationshipGroup , playerRelationship);  

Then when you spawn a ped, simply:

Ped.RelationshipGroup = someRelationshipGroup;

Check this post out, it has some code regarding relationship groups.
https://forums.gta5-mods.com/post/167378

Relationship groups do not work like a traditional "group", A traditional group will act like a unit, all members following its leader. If the leader attacks, the members attack. If someone attacks the leader its members will defend him.

Relationship groups define how peds treat each other, peds in the same relationship group can fight together, but they will not follow each other.

Peds in a relationship group that Hate another Relasionship group will not actively seek out peds they hate, but they will attack the ped on sight and will generally not attack peds who have the same relationship group. (this is how all Ballas peds will fight together against Families, but not attack each other or follow each other)

Relationships can be configured as follows:
Hate>Dislike>Neutral>Respect>Like>Companion.

A peds can be in a group and also be in a relasionship group.

Try adding them all to a relationship group that Hates the player.

@prismspecs
Look at the PedHash enum in SHVDN

PedHash.Business02AMY

Or you could make your own.

@prismspecs
Not tested but have you tried setting the ped to not be a cop before changing the relationship?

https://alloc8or.re/gta5/nativedb/?n=0xBB03C38DD3FB7FFD

I noticed someone in the comments section for this script enquired about making certain props breakable, but only if they are hit really hard, size of vehicle and speed being taken into consideration.
Well i was interested in such a feature myself so i did some playing around, and got something im pretty happy with.

public class ColStr : Script
    {
        bool DEBUG = true;
        Veh veh = null;
        int time = 0;
        float EnergyNeededToBreak = 600;
        List<Prop> frozenProps = new List<Prop>();

        List<int> propHashes = new List<int> { -365135956, 589548997, 267702115, 1043035044, -753093121, -1059778192, -1529663453,
                -655644382, -1114695146, 431612653, 681787797, 326972916, -1454378608, -614573584, -306910109, 1821241621, 1847069612, 865627822, -1063472968,
                -1684988513, 1327054116, 1021745343, 729253480, -1161709063, 862871082, 1393636838, -1222468156, -805588751, 1380570124, -259356231 };

        public ColStr()
        {
            Tick += OnTick;
        }

        private void OnTick(object sender, EventArgs e)
        {
            Ped playerPed = Game.Player.Character;

            if(Game.GameTime > time + 1000)
            {
                time = Game.GameTime;
                Prop[] nearbyProps = World.GetNearbyProps(playerPed.Position, 100f).Where(p => propHashes.Contains(p.Model.Hash) && !frozenProps.Contains(p) && p.MaxHealth == p.Health && p.IsUpright).ToArray();
                if(nearbyProps.Count() > 0)
                {
                    foreach(Prop prop in nearbyProps)
                    {
                        frozenProps.Add(prop);
                        prop.FreezePosition = true;
                    }
                }
            }            
            foreach(Prop prop in frozenProps.ToList())
            {
                if(prop == null || !prop.Exists())
                {
                    frozenProps.Remove(prop);
                }
            }

            if(DEBUG)
            {
                UIText propInfo = new UIText(frozenProps.Count.ToString(), new Point(10, 10), 0.2f, Color.WhiteSmoke, 0, true, true, true);
                propInfo.Draw();
            }
            

            if (veh == null)
            {
                if(playerPed.IsInVehicle())
                {
                    veh = new Veh(playerPed.CurrentVehicle);
                }
            }
            else
            {
                if (!playerPed.IsInVehicle())
                {
                    veh = null;                    
                }
                else
                {
                    veh.calcEnergy();
                    if(DEBUG) DrawDebug();
                    if(veh.Vehicle.HasCollidedWithAnything)
                    {
                        foreach(Prop prop in frozenProps)
                        {                            
                            if(veh.Vehicle.IsTouching(prop))
                            {
                                if(DEBUG) UI.Notify("Player hit prop @ " + veh.lastEnergy);
                                if(veh.lastEnergy > EnergyNeededToBreak)
                                {
                                    prop.FreezePosition = false;
                                    prop.MarkAsNoLongerNeeded();
                                }                                                                                               
                                break;
                            }
                        }
                    }
                }
            }
        }

        private void DrawDebug()
        {
            string vehString = veh.curEnergy.ToString();
            Vector2 tPos = World3DToScreen2d(new Vector3(veh.Vehicle.Position.X, veh.Vehicle.Position.Y, veh.Vehicle.Position.Z + 0.5f));
            tPos.X = 1280 * tPos.X;
            tPos.Y = 720 * tPos.Y;
            UIText vehInfo = new UIText(vehString, new Point((int)tPos.X, (int)tPos.Y), 0.2f, Color.WhiteSmoke, 0, true, true, true);
            vehInfo.Draw();
        }

        class Veh
        {
            public Vehicle Vehicle;
            float VehMass;
            public float curEnergy;
            public float lastEnergy;
            public Veh(Vehicle _veh)
            {
                Vehicle = _veh;                
                VehMass = Vehicle.Model.GetDimensions().X * Vehicle.Model.GetDimensions().Y * Vehicle.Model.GetDimensions().Z;
            }
            public void calcEnergy()
            {
                lastEnergy = curEnergy;
                curEnergy = VehMass * Vehicle.Velocity.Length();
            }
        }

        public static Vector2 World3DToScreen2d(Vector3 pos)
        {
            OutputArgument x2dp = new OutputArgument();
            OutputArgument y2dp = new OutputArgument();

            Function.Call(Hash._0x34E82F05DF2974F5, pos.X, pos.Y, pos.Z, x2dp, y2dp); //GET_SCREEN_COORD_FROM_WORLD_COORD
            return new Vector2(x2dp.GetResult<float>(), y2dp.GetResult<float>());
        }
    }

Feel free to use any of this if you want too, or send me a message if your not sure what something is doing.

Try

List<Prop> props = World.GetNearbyProps().Where(p => propHashes.Contains(p.Model.Hash) && !p.FreezePosition).ToList();

The result should only contain props that need to be frozen, so all you would need to do is.

if(props.Count > 0)
{
   foreach(Prop prop in props)
   {
      prop.FreezePosition = true;
   }
}

Note im still using SHVDN 2, so that would be why some syntax is different.

Edit: Just did some testing and you can do

Prop[] props = World.GetNearbyProps().Where(p => propHashes.Contains(p.Model.Hash) && !p.FreezePosition).ToArray();
if(props.Count() > 0)
{
   foreach(Prop prop in props)
   {
      prop.FreezePosition = true;
   }
}

For stuff like this you can quite easily run at say 350-500ms and get everything around the player just fine.
Might also want to consider keeping a reference of objects you have already done this operation on, and then only operating on objects you have not. (unless it needs overriding each frame ofc)

Might be a better idea to get all the HashKeys when the script first loads, store them in a list and use that instead of asking the game engine to convert all them strings to hashes every tick.
Function calls can be quite a burden, id try to minimise them as much as possible.

These scripts:
https://www.gta5-mods.com/tools/v1290-decompiled-scripts-rootcause